[automatic failover] Fix misleading timing information for AA scenario test #4303
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes misleading timing information in the Active-Active failover scenario test by ensuring that only commands executed on the failed cluster are counted as failover-related failures.
- Adds a check to determine if a command is being executed on the originally active cluster
- Modifies the failure counting logic to only increment when the command was attempted on the failed cluster
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| int maxTries = 500; | ||
| int retryingDelay = 5; | ||
| while (true) { | ||
| boolean attempToExecuteOnFailedCluster = false; |
There was a problem hiding this comment.
Corrected spelling of 'attemp' to 'attempt'.
Copilot uses AI. Check for mistakes.
atakavci
force-pushed
the
ali/aa-scenario_test
branch
from
ab84e38 to
70bc41f
Compare
* - replace EchoStrategy with PingStrategy * - fix doc
|
…epting MultiDbConnectionProvider (redis#4316) * Remove UnifiedJedis(MultiDbConnectionProvider) experimental constructor The recommended way to create MultiDbClient is using MultiDbClient.builder(). Update all tests to use the builder pattern. Fixes redis#4307 * revert unintentional change in MultiDbClientBuilder
commit 297279e Author: Igor Malinovskiy <[email protected]> Date: Thu Oct 9 13:06:10 2025 +0200 Add v6 and v7 migration guides (redis#4315) * Add migration guide for v7 * Move all migration guides to subfolder * Update readme: - Bump client version - Update list of supported Redis versions - Remove references to JedisPool - Remove reference to Google Group * Remove duplicated content in the migration guide * Update README.md Co-authored-by: Copilot <[email protected]> * Add missing v5 to v6 migration guide * Fix broken link * Update outdated modules section in README --------- Co-authored-by: Copilot <[email protected]> commit 3645601 Author: Ivo Gaydazhiev <[email protected]> Date: Thu Oct 9 13:53:02 2025 +0300 Dedicated profile for running Scenario tests (redis#4312) * Dedicated profile for running Scenario tests to run only scenario tests mvn -Pscenario-tests clean verify * format * remove import after rebase conflict * fix RedisRestAPIIT scenario test - increase expected bdb's count to account for additional db added to test env - fix incorrect bdbid used for lag-aware availablity checks now using bdb of'"re-active-active" * fix LagAwareStrategySslIT scenario test - Now exception is propagated in case of ssl connection errors instead of returning UNHEALTHY - updated the test to current expectations - Enhanced test to ensure untrusted default certificate * java 8 compatibility * remove @tag("integration") from IntegrationTest* to avoid multiple runs of same test --------- Co-authored-by: Igor Malinovskiy <[email protected]> commit 07bf3b0 Author: Igor Malinovskiy <[email protected]> Date: Thu Oct 9 12:00:36 2025 +0200 [automatic failover] Update failover docs (redis#4314) Update failover docs - Add migration guide from 6.x to 7.0 - Add instructions on optional deps - Clean up wording to refer to multiDbClient instead of connection provider commit 158e726 Author: Igor Malinovskiy <[email protected]> Date: Thu Oct 9 11:14:28 2025 +0200 Remove deprecated constructors, classes and JedisSharding (redis#4311) * Remove JedisSharding * Remove deprecated constructors in UnifiedJedis * Clean up UnifiedJedisConstructorReflectionTest * Remove remaining ShardedCommandArguments * Remove deprecated PipelineBase * Remove deprecated TransactionBase * Remove unused attr in MultiDbTransaction commit 5db1a39 Author: Igor Malinovskiy <[email protected]> Date: Thu Oct 9 10:04:06 2025 +0200 Remove spellcheck (redis#4309) Nowadays, AI reviewing tools like CoPilot catch spellcheck issues better than pyspelling without a burden of maintaining wordlist.txt
atakavci
force-pushed
the
ali/aa-scenario_test
branch
from
2449392 to
35e54c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.